dots-hyprland
dots-hyprland copied to clipboard
Appearence Enhancements
- Adds wallpaper selector and thumbnail generator that blind perfictly with the system
- Multi Lingual WS Indicator
- Transforming the entire Color generation for Matugen for better yet more flexible mechanism
SS :
Credits : @sh1zicus for the awesome Work with the wallselector
are you sure you're only adding a wallpaper selector? because im seeing a hella lot of other stuff, like japanese style workspace indicators and you commeneted out cheatsheet module
when first used ur config i got keybinds error so i didnt bother to fix it just commented the line + i intended to make another pr for the unicode support for the workspaces where it support multiple languages natively not just 10 char currently supporting
- thai
- arabic
- normal "english"
- japanese
- chinese
- idk
when first used ur config i got keybinds error so i didnt bother to fix it just commented the line
Did you mean cheatsheet error?
While I should admit that your work is cool and valuable, you should not just comment functional things (e.g. cheatsheet, music control) out, else we can not accept the PR, as we can not accept functional loss for insufficient reason.
are you sure you're only adding a wallpaper selector? because im seeing a hella lot of other stuff, like japanese style workspace indicators and you commeneted out cheatsheet module
And yes, here's the problem. @Pharmaracist this PR has its content mismatching with the title. And you've already have another opened PR doing another lots of modifications...
when first used ur config i got keybinds error so i didnt bother to fix it just commented the line
Did you mean cheatsheet error?
While I should admit that your work is cool and valuable, you should not just comment functional things (e.g. cheatsheet, music control) out, else we can not accept the PR, as we can not accept functional loss for insufficient reason.
i forgot to uncomment that so i want to know first if you really need the hyprland_level transparency toggle or not so i can commit it
are you sure you're only adding a wallpaper selector? because im seeing a hella lot of other stuff, like japanese style workspace indicators and you commeneted out cheatsheet module
And yes, here's the problem as @Pharmaracist this PR is with wrong title. And you've already have another opened PR doing another lots of modifications...
i can close the other one for to be one pr at a time
ill make another pr since the tweaks arent applied after changing the title idk that much about gh
so for the musiccontrol it still works for me but the old py implementation thing idk what it was doing but we can use pywal separately for it since we really dont rely on it for everthing now but this will be at the cost of some interference with pywalfox since matugen patches it by masking
and i made the
dynamic resources friendly cava service + implemented it with music controls kinda similer to the knovel knocks setup and can be adjusted by vpack
so i made some very useful edits were now if you add / remove any images it auto generate /remove it and its thumbnail ill update the PR soon
done ✅
so for the musiccontrol it still works for me but the old py implementation thing idk what it was doing but we can use pywal separately for it since we really dont rely on it for everthing now but this will be at the cost of some interference with pywalfox since matugen patches it by masking
hmm material > pywal for readability can we use matugen for it? can matugen run with a separate configuration so it doesn't mess with the non-music stuff?
yes we can specify certain toml file for it
the only conflicting thing here with the pywal is pywalfox we can disable this or redirect pywalfox for other output_path
oh right i don't really care about pywalfox, but maybe ill just remove the mixing with pywal part for the music controls to simplify things. not today, later when i actually take a look at matugen stuff
ill also try to find a workaround without sacrificing pywalfox for the folks using firefox "using firefox w gtk is pure pain"
so for the wallselect module it had some problems
- it needs to manually generate thumbnails then restart ags can get around this by seetting glib watcher but why ?
- it its very resources heavy the more images u get the more ram/cpu it will need
Steps to Fix
- [x] using pixbuf to load the image with different modes
- [x] auto caching through the native glib/gio apis
- [x] add different preview qualities cuz not every user has 4090 --actually idk if gpu acceleration actually appliable on ags if it does it will be much esier tasks
- [x] async image loading
- [x] uses lazy loading / pages approach
- [ ] maybe moving the whole colorscheme module to be with the wallselect and be like an appearance panel or sth
huh i havent tested this, how much more resource it use
oh my gosh OH MY GOSH.
Then somenone need to make a FULLY FUNCTIONING FILE PICKER. (I did, but its in miscutils and not m3 yet.) Also a EXIT THING (ex. trying to exit without saving some files in vscode) which.... you need to compile vscode yourself :P
@enessmr please do not leave personal comments that do not contribute to the issue/commit you comment on
error loading wallpapers everytime
@Pharmaracist can you fix it
with wallpaper also:
it still same
Generate thumbs first
Generate thumbs first
@Pharmaracist Still the same after
pass the logs and make sure that imagemagick is installed
(com.github.Aylur.ags:1300644): Gjs-WARNING **: 14:59:42.515: Unhandled promise rejection. To suppress this warning, add an error handler to your promise chain with .catch() or a try-catch block around your await expression. Stack trace of the failed promise:
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:263:34
huh thats when i generate thumbs and
~ 🐍v2.7.18
🞈 imagemagick
^C⏎
~ 🐍v2.7.18
🞈 yay -S imagemagick
Sync Dependency (1): imagemagick-7.1.1.44-1
[sudo] password for hyprlanduser:
uyarı: imagemagick-7.1.1.44-1 güncel -- yeniden kuruluyor
paket bağımlılıkları çözümleniyor...
varsa paketler arası çakışmalara bakılıyor...
Paketler (1) imagemagick-7.1.1.44-1
Toplam İndirme Boyutu: 8,67 MiB
Toplam Kurulum Boyutu: 23,07 MiB
Güncelleme Boyutu: 0,00 MiB
:: Kuruluma onay veriyor musunuz? [E/h] e
:: Paketler alınıyor...
imagemagick-7.1.1.44-1-x86_64 8,7 MiB 17,0 MiB/s 00:01 [################################] 100%
(1/1) anahtarlıktaki anahtarlar kontrol ediliyor [################################] 100%
(1/1) paket bütünlüğü kontrol ediliyor [################################] 100%
(1/1) paket dosyaları yükleniyor [################################] 100%
(1/1) dosya çakışmaları kontrol ediliyor [################################] 100%
(1/1) disk alanı kontrol ediliyor [################################] 100%
:: Paket değişiklikleri işleniyor...
(1/1) tekrar kuruluyor imagemagick [################################] 100%
:: Bağlantılı işlemler listesi çalışıyor...
(1/2) Arming ConditionNeedsUpdate...
(2/2) Checking for old perl modules...
~ 🐍v2.7.18
🞈 imagemagick
fish: Unknown command: imagemagick
~ 🐍v2.7.18
🞈
@Pharmaracist any other deps? available fixes?????
I still use python 2.7.18 due to android deploys i make for p4wifi when i use 3 the syntax is different and it gives error
I also use pyenv but thats temporary
for proof (that gjs warnings are everytime it tries to generate thumbs)
https://github.com/user-attachments/assets/07aad741-344e-44a3-80b0-f972714087cd
For proof of smth
sry for bad quality :(
obs has some visual things that make it awful
its not like androids screen recorder from lineageos
wait the fuc-
@Pharmaracist where is the script?
@Pharmaracist Is this the same script you use?
#!/bin/bash
# Directories
WALLPAPER_DIR="${HOME}/Pictures/Wallpapers"
THUMBNAIL_DIR="${WALLPAPER_DIR}/thumbnails"
# Create the thumbnails directory if it doesn't exist
mkdir -p "${THUMBNAIL_DIR}"
# Iterate over image files in the wallpaper directory
find "${WALLPAPER_DIR}" -maxdepth 1 -type f \( -iname "*.jpg" -o -iname "*.jpeg" -o -iname "*.png" -o -iname "*.gif" -o -iname "*.webp" -o -iname "*.tga" -o -iname "*.tiff" -o -iname "*.bmp" -o -iname "*.ico" \) | while read -r image; do
filename=$(basename "${image}")
thumbnail="${THUMBNAIL_DIR}/${filename}"
# Check if thumbnail already exists
if [[ -f "${thumbnail}" ]]; then
echo "Thumbnail already exists for ${filename}, skipping..."
continue
fi
# Generate thumbnail using ImageMagick
convert "${image}" -resize 200x200 "${thumbnail}"
echo "Thumbnail created for ${filename}"
done