httpx
httpx copied to clipboard
Fix httpx is not encoding with symbol '%s' (#3140)
Fix httpx is not encoding with symbol '%s' (#3140) Add url parsing test
Summary
Checklist
- [x] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
- [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
- [ ] I've updated the documentation accordingly.
Hi @T-256, will the code change encode every "%" sent into uri as "%25" ?
Hi @T-256, will the code change encode every "%" sent into uri as "%25" ?
Yes, if it is invalid percent-encoded.
when can we merge this changes? @tomchristie
Hello, could you look at if this PR fixes the cases of bad % character encoding that are raised in https://github.com/encode/httpx/discussions/3135?
I think the change in this PR (to only encode % if it would result in invalid percent-encoding) is a distraction from the real issue.
Thanks. I think this is superseeded by #3187.
I tried the same on http 0.27.0, still having the same issue.