httpx icon indicating copy to clipboard operation
httpx copied to clipboard

Fix httpx is not encoding with symbol '%s' (#3140)

Open Tunglies opened this issue 1 year ago • 6 comments
trafficstars

Fix httpx is not encoding with symbol '%s' (#3140) Add url parsing test

Summary

Checklist

  • [x] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [ ] I've updated the documentation accordingly.

Tunglies avatar Mar 14 '24 05:03 Tunglies

Hi @T-256, will the code change encode every "%" sent into uri as "%25" ?

heysarthak avatar Mar 19 '24 07:03 heysarthak

Hi @T-256, will the code change encode every "%" sent into uri as "%25" ?

Yes, if it is invalid percent-encoded.

T-256 avatar Mar 19 '24 19:03 T-256

when can we merge this changes? @tomchristie

heysarthak avatar Mar 26 '24 05:03 heysarthak

Hello, could you look at if this PR fixes the cases of bad % character encoding that are raised in https://github.com/encode/httpx/discussions/3135?

I think the change in this PR (to only encode % if it would result in invalid percent-encoding) is a distraction from the real issue.

jhominal avatar Mar 27 '24 09:03 jhominal

Thanks. I think this is superseeded by #3187.

lovelydinosaur avatar May 02 '24 16:05 lovelydinosaur

I tried the same on http 0.27.0, still having the same issue.

heysarthak avatar Aug 26 '24 06:08 heysarthak