httpx icon indicating copy to clipboard operation
httpx copied to clipboard

Allow str in form files.

Open waterfountain1996 opened this issue 3 years ago • 1 comments
trafficstars

Closes: #2069

Changed FileField to allow str content, but raise exception on text buffers.

waterfountain1996 avatar Feb 10 '22 09:02 waterfountain1996

Great - thanks!

I've tweaked the description to "Closes: #2069", so that the issue gets a backlink to here, and so that merging this would auto-close the issue. Also retitled the PR, dropping the issue number.

I'm... not sure which of the two possible resolutions suggested in #2069 we should go for.

Possibly(?) in favour of making the docs change, rather than making the behaviour change.

That would still give us the option of making the behaviour change at a later date if we think that's a good thing to do, because adding str support there isn't be a breaking API change. (But removing it is.)

Not sure.

lovelydinosaur avatar Feb 10 '22 13:02 lovelydinosaur