embulk-output-bigquery icon indicating copy to clipboard operation
embulk-output-bigquery copied to clipboard

Support description of columns and tables

Open fagai opened this issue 3 years ago • 7 comments
trafficstars

related: #127 add tests. and fixed tests.

fagai avatar Jan 18 '22 13:01 fagai

@fagai Thank you for adding tests.

kyoshidajp avatar May 30 '22 02:05 kyoshidajp

Hi, maintainers! Is this still under review? I need this feature, so I'm hoping this PR will be merged soon. Thank you maintainers for your time to maintain this project.

masaushi avatar Sep 05 '22 00:09 masaushi

Hello, @fagai. I'm a new maintainer. Could you resolve conflict this PR? I'll review this PR. Or, I'll create another PR later.

hiroyuki-sato avatar Mar 01 '24 13:03 hiroyuki-sato

@hiroyuki-sato I resolved the conflict.

fagai avatar Mar 01 '24 13:03 fagai

@fagai Thank you for your work!.

Does this PR work as you expected? It seems the column is OK. But, the table doesn't set as you expected. What am I wrong?

out:
  type: bigquery
  mode: append
  # snip
  table: hello_embulk
  source_format: NEWLINE_DELIMITED_JSON
  column_options:
  - name: purchase
    description: hogehogehoge12345
  description: hogehoge

column: OK

スクリーンショット 2024-03-01 22 43 23

table: NG??

スクリーンショット 2024-03-01 22 43 30

hiroyuki-sato avatar Mar 01 '24 13:03 hiroyuki-sato

@hiroyuki-sato Fixed an issue where config values ​​were not being read.

I don't have a deep understanding of ruby, so I may be wrong.

fagai avatar Mar 01 '24 15:03 fagai

Thanks LGTM👍

スクリーンショット 2024-03-03 0 30 08

@joker1007 Could you check this PR when you get a chance?

hiroyuki-sato avatar Mar 02 '24 15:03 hiroyuki-sato

Thanks!

hiroyuki-sato avatar Mar 04 '24 07:03 hiroyuki-sato