rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

Amend RFC 0821 given implementation tweaks

Open chriskrycho opened this issue 3 years ago • 1 comments
trafficstars

Authoring the types for DefinitelyTyped revealed a number of issues, which were also surfaced previously while working on Ember's internal versions of these types. Accordingly, align the types as defined here with Ember's internal representation of them, and clarify why the types are the way they are when they may not seem especially sensical. Also add a FullName export for convenience.

As a bonus, add a table of contents and make sure the order of the sections matches the order described in prose.

chriskrycho avatar Aug 02 '22 15:08 chriskrycho

We are all agreed this is 👍🏼 and it’s going into FCP-to-merge.

chriskrycho avatar Aug 05 '22 18:08 chriskrycho

Looks good, merging!

chriskrycho avatar Aug 12 '22 18:08 chriskrycho