rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

Deprecate string based actions

Open Gaurav0 opened this issue 5 years ago • 7 comments
trafficstars

For issue #629

Rendered

Gaurav0 avatar May 23 '20 18:05 Gaurav0

I really like this, but there is one very important use case that we need to cover before we can do this. And this is the Route#refresh method.

While you proposed a new refresh method on the RouterService, which is good, it does not cover this use-case! There must be a way to refresh the current Route from the template/controller.

luxzeitlos avatar May 29 '20 17:05 luxzeitlos

I really like this, but there is one very important use case that we need to cover before we can do this. And this is the Route#refresh method.

While you proposed a new refresh method on the RouterService, which is good, it does not cover this use-case! There must be a way to refresh the current Route from the template/controller.

Why can't you inject the router service into the controller or whatever component backs the template?

Gaurav0 avatar May 29 '20 18:05 Gaurav0

The problem is that I only want to refresh the current route, not all parent routes.

luxzeitlos avatar May 29 '20 18:05 luxzeitlos

Is there still interest in moving this forwards?

wagenet avatar Jul 25 '22 14:07 wagenet

@ef4 Someone would need to take over this from me.

Gaurav0 avatar Jul 26 '22 05:07 Gaurav0

@chriskrycho do you want to include this in #832?

wagenet avatar Jul 29 '22 23:07 wagenet

That would make sense to me. I keep forgetting these still exist—it got at least partially cleaned up by removing sendAction for v4.0, just needs the rest done.

chriskrycho avatar Jul 30 '22 12:07 chriskrycho

Thanks for your work here! This will be addressed as part of #832.

wagenet avatar Jan 13 '23 21:01 wagenet