ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

Update CHANGELOG.md – add `Upgrade the Glimmer VM from 0.84.3 to 0.85.13` to release notes of `v5.6.0`

Open johanrd opened this issue 1 year ago • 2 comments

See https://github.com/emberjs/ember.js/compare/v5.5.0...v5.6.0

I experienced some weird regressions that could not have come from the other changes in the logs, so it may be relevant for others to have this pointed out as well.

johanrd avatar Feb 10 '24 23:02 johanrd

same -- in particular, shadow-dom support has regressed for me related: https://github.com/emberjs/ember.js/issues/20644

NullVoxPopuli avatar Feb 10 '24 23:02 NullVoxPopuli

And the regression with the bundle size probably comes from there.

boris-petrov avatar Feb 12 '24 17:02 boris-petrov

Thank you!

kategengler avatar Mar 04 '24 20:03 kategengler

@kategengler great, thanks, yet, maybe I committed to the wrong file, as the release notes of 5.6.0 still does not include the line about glimmer-vm?

johanrd avatar Mar 08 '24 13:03 johanrd

@johanrd You got the correct file.

There's two different things here:

The CHANGELOG.md file shipped with 5.6.0 will never change -- it has been released and we wouldn't backport and release just for a changelog change.

Release notes on GitHub do not source from CHANGELOG.md but are manually created at release time by my pasting in the changelog text. I'll update it now.

kategengler avatar Mar 08 '24 14:03 kategengler