ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

provide debug utilities for inspector via event communication

Open patricklx opened this issue 1 year ago • 7 comments

this would allow inspector to communicate with emberjs without relying on any globals like the define, require functions and without the barrel file. it would be required for inspector to provide more functionality when using vite or also when building with embroider webpack and staticEmberSources=true

would also like to https://github.com/glimmerjs/glimmer-vm/pull/1489 as part of this

https://github.com/emberjs/ember-inspector/pull/2554

patricklx avatar Nov 28 '23 14:11 patricklx

maybe @chancancode ?

kategengler avatar Dec 12 '23 16:12 kategengler

We now need this to proceed with https://github.com/emberjs/rfcs/pull/1015

For the VM side of this, https://github.com/glimmerjs/glimmer-vm/pull/1489, benchmarks are running, so we'll know if this is safe.

NullVoxPopuli avatar Jun 11 '24 14:06 NullVoxPopuli

Are these things not already accessible via their existing private import paths?

ef4 avatar Jun 14 '24 18:06 ef4

Not with ember static source enabled. Then it's not accessible.

patricklx avatar Jun 14 '24 19:06 patricklx

Biggest issue is the boot load event. https://github.com/emberjs/ember.js/blob/main/packages/ember/barrel.ts#L749

And the whole ember source needs to be loaded before inspector can access it. (With AMD) There have been multiple issues around that in the past.

patricklx avatar Jun 14 '24 19:06 patricklx

E.g. https://github.com/emberjs/ember-inspector/pull/2051

As an example

patricklx avatar Jun 14 '24 19:06 patricklx