ember-inspector icon indicating copy to clipboard operation
ember-inspector copied to clipboard

Convert components to angle bracket syntax

Open RobbieTheWagner opened this issue 6 years ago • 9 comments

We should be able to support using angle bracket components, in inspector itself. We need to fix the build first, but slowly converting components over would move us in the right direction.

RobbieTheWagner avatar Mar 18 '19 05:03 RobbieTheWagner

Shall I take a look at this?

prasannavijayan avatar Mar 24 '19 07:03 prasannavijayan

+1 to slowly moving them over. A Big Bang PR will definitely cause some errors.

nummi avatar Mar 24 '19 18:03 nummi

I need to cut some new branches, so we can get the build working here again, then we can begin work on this.

RobbieTheWagner avatar Mar 25 '19 15:03 RobbieTheWagner

Is this still something that needs to be done? I can pick it up if so

akankshadharkar avatar Apr 01 '21 21:04 akankshadharkar

@akankshadharkar yes, it is something that needs to be done. We would love the help, if you have the time!

RobbieTheWagner avatar Apr 05 '21 01:04 RobbieTheWagner

@rwwagner90 Awesome, I'll look over the requirements and take this up then :)

akankshadharkar avatar Apr 06 '21 05:04 akankshadharkar

Is this still pending? I can take this up. I Will need some more info on the requirements and then I can start working on it.

sumitd94 avatar Jun 26 '21 08:06 sumitd94

Hi @sumitd94, yes this still needs to be completed. Please feel free to convert things a component or two at a time and submit PRs! No real requirements other than converting to angle bracket syntax.

RobbieTheWagner avatar Jun 27 '21 16:06 RobbieTheWagner

Ok Sure, I will pick this up and raise PRs. If possible could you please let me know one component which is not using the angle bracket invocation? just for reference purposes. @rwwagner90

sumitd94 avatar Jun 29 '21 14:06 sumitd94