ember-cli-addon-docs icon indicating copy to clipboard operation
ember-cli-addon-docs copied to clipboard

Ember 3.8 - History replaceState error after deploying to Github

Open crhayes opened this issue 6 years ago • 7 comments

Hello,

I recently ran through the Quickstart with a newly created addon (Ember 3.8) and received the following error:

image

The URL in the error is https://webcomponentlibrary/versions/master//WebComponentLibrary/versions/master/

Any ideas as to what I need to fix?

Thanks!

crhayes avatar Mar 05 '19 01:03 crhayes

/cc @samselikoff sorry to bug you... anything come to mind re ^^^ ?

crhayes avatar Mar 05 '19 17:03 crhayes

I've tried a number of combinations of dependencies and discovered that (using ember-cli-addon-docs: 0.6.5):

  • ember-source: 3.8.* with ember-cli: 3.7.* works
  • ember-source: 3.8.* with ember-cli: 3.8.* does not work

crhayes avatar Mar 05 '19 19:03 crhayes

I can confirm this. It has something to do with those double slashes on ember-cli 3.8.x.

miguelcobain avatar Mar 08 '19 18:03 miguelcobain

Try master. I think is already fixed from one of my previous PR 😄 #332

ming-codes avatar Mar 08 '19 22:03 ming-codes

@crhayes @miguelcobain just released 0.6.6, want to give it a shot?

samselikoff avatar Mar 09 '19 17:03 samselikoff

It works for me!

miguelcobain avatar Mar 09 '19 19:03 miguelcobain

I think I am still seeing this in ember-cli 3.9 and latest addon docs. Is anyone else hitting this again?

You can see the error here https://shipshapecode.github.io/ember-flatpickr/

RobbieTheWagner avatar Apr 11 '19 04:04 RobbieTheWagner