cli-guides icon indicating copy to clipboard operation
cli-guides copied to clipboard

Show the ember-cli logo above the TOC

Open mansona opened this issue 6 years ago • 3 comments

For the cli-guides we should show the ember-cli logo in the top left just above the TOC.

screenshot 2018-12-11 at 11 18 08

As we are using guidemaker for the ember-cli guides we will need to make this a configurable feature of the guidemaker-ember-template so that any other projects using the same template can optionally configure this logo

Todo

  • [ ] add a configuration entry for logo to the guidemaker block of the cli-guides https://github.com/ember-learn/cli-guides/blob/master/config/environment.js#L33
    • I guess it doesn't really need to be in the guidemaker block 🤔 but it needs to be somewhere in that config
  • [ ] if the logo is configured it should be used in the template above the TOC
    • it might be worth putting it in this file that renders the left column: https://github.com/ember-learn/guidemaker-ember-template/blob/master/app/templates/version.hbs

mansona avatar Dec 11 '18 11:12 mansona

@mansona I don't understand this question. Where are this logo? do you want me to put it in guidemaker-ember-template? and make it configurable?

villander avatar May 15 '19 01:05 villander

@villander yes this would be a change to guidemaker-ember-template and it would need to be configurable (so it doesn't show up in other sites that use this template)

mansona avatar May 15 '19 07:05 mansona

Hi @mansona,

In looking through this I see that the logo exists at https://github.com/emberjs/website/blob/master/source/images/brand/ember_CLI-Light.png.

Are you ok with me creating a copy of this here: https://github.com/ember-learn/guidemaker-ember-template/tree/master/public/images/logos? I don't readily know how else I can make this asset available in the guidemaker repo without porting it over.

Regardless. I plan to try and assemble PR's for this. Thanks.

cah-john-ryan avatar Oct 28 '20 20:10 cah-john-ryan