ember-test-helpers-codemod icon indicating copy to clipboard operation
ember-test-helpers-codemod copied to clipboard

Published 20 hours ago • verified publisher icon ember-codemods

Helpers find/findAll should not be used in user-land test code

Open synaptiko opened this issue 6 years ago • 0 comments
trafficstars

According to the discussion here https://github.com/emberjs/ember-test-helpers/issues/351#issuecomment-456881507 find/findAll should be avoided. I found the reason here: https://github.com/simonihmig/ember-test-helpers-codemod/issues/6 but maybe it should be mentioned somewhere that it's not recommended way and that one should refactor his code after applying the codemod (or apply the second one and fix the places where this is incorrect).

synaptiko avatar Jan 24 '19 14:01 synaptiko