ember-angle-brackets-codemod icon indicating copy to clipboard operation
ember-angle-brackets-codemod copied to clipboard

Possible to run offline (not using puppeteer / dev server)?

Open jacobq opened this issue 5 years ago • 6 comments

I would like to run this codemod on an ember-electron app, but it currently won't run properly via ember s since it relies on requireNode in some places. Other codemods that I've used seemed to operate solely on the source files, which hasn't been a problem. Is the only way that I can use this codemod to first modify my app such that it will gracefully handle running outside of the electron context?

Related: #217 #200

Maybe also something like this could help? https://github.com/nondanee/puppeteer-electron

jacobq avatar Feb 13 '20 17:02 jacobq

version 2 can be used to run offline. It uses a best guess strategy so there might be some conversion errors

tylerturdenpants avatar Feb 13 '20 19:02 tylerturdenpants

version 2 can be used to run offline. It uses a best guess strategy so there might be some conversion errors

Ah, perfect, thank you. I think that will be good enough for me as I don't mind giving the mod some hints and doing a few manual corrections myself.

Is there some documentation that describes why the live server is needed / how it is able to do a better job than, say, version 2?

jacobq avatar Feb 13 '20 19:02 jacobq

@jacobq did you ever figure this out? I'm hitting errors with puppeteer.

RobbieTheWagner avatar May 05 '20 18:05 RobbieTheWagner

@jacobq did you ever figure this out? I'm hitting errors with puppeteer.

IIRC I just used the old version (which doesn't use puppeteer).

jacobq avatar May 06 '20 05:05 jacobq

@rwwagner90 Can you try this now, since we have made telemetry optional

npx github:ember-codemods/ember-angle-brackets-codemod --no-telemetry ./my-path

rajasegar avatar May 06 '20 09:05 rajasegar

@rajasegar you have to pass --no-telemetry? I tried omitting --telemetry as the docs suggested. If we have to manually pass --no-telemetry we should probably document that.

RobbieTheWagner avatar May 06 '20 14:05 RobbieTheWagner