eslint-plugin-ember icon indicating copy to clipboard operation
eslint-plugin-ember copied to clipboard

no-unused-expressions

Open amk221 opened this issue 1 year ago • 4 comments

Class based gjs files get linted fine. But template only gjs files fail like this:

Reproduction:

https://github.com/amk221/-ember-template-imports-eslint-unused-expression/commit/ff4504e4400287e177a5151c3f999fa5a8fae997

Versions:

├── @babel/[email protected]
├── @babel/[email protected]
├── @babel/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]

amk221 avatar Dec 20 '23 14:12 amk221

@NullVoxPopuli @patricklx

bmish avatar Dec 20 '23 14:12 bmish

its using eslint-plugin-ember@11.12.0 I do not see this issue in the alpha release. @amk221 can you try to alpha release and check if you still have the issue?

patricklx avatar Dec 20 '23 14:12 patricklx

Thanks, yes that does fix it

It it instead output

 Parsing error: This experimental syntax requires enabling one of the following parser plugin(s): "jsx", "flow", "typescript". (1:0)

I don't know what that is, but happy that its fixed in 12 :)

amk221 avatar Dec 20 '23 15:12 amk221

Looks like eslint ember plugin fails to notify to setup the correct config in this case: https://github.com/ember-cli/eslint-plugin-ember?tab=readme-ov-file#gtsgjs

patricklx avatar Dec 20 '23 15:12 patricklx