ember-twiddle icon indicating copy to clipboard operation
ember-twiddle copied to clipboard

Published 20 hours ago • verified publisher icon ember-cli

Edge support

Open broerse opened this issue 10 years ago • 10 comments
trafficstars

ember-twiddle should be made compatible with the new Windows 10 Edge browser.

broerse avatar Aug 01 '15 05:08 broerse

It seems we need something like this to do it: https://github.com/jugglinmike/srcdoc-polyfill/blob/master/srcdoc-polyfill.js

broerse avatar Aug 01 '15 05:08 broerse

Yes! There is now an official npm version. Perhaps we can include it now?

https://www.npmjs.com/package/srcdoc-polyfill

broerse avatar Oct 03 '15 11:10 broerse

@broerse Does it work with sandboxed iframes?

Gaurav0 avatar Oct 05 '15 14:10 Gaurav0

@Gaurav0 I am not an expert but this sandbox="allow-scripts allow-same-origin" http://jsfiddle.net/wUvrF/1/ works in Edge.

broerse avatar Oct 05 '15 14:10 broerse

We cannot allow-same-origin for security reasons.

Gaurav0 avatar Oct 05 '15 15:10 Gaurav0

As I said I am not the expert. Perhaps it is not needed. Can we create a test I can run on Edge?

broerse avatar Oct 05 '15 17:10 broerse

@broerse A pr with the srcdoc polyfill for edge would be welcome. The sandboxing policy cannot be changed for security reasons. I cannot test in Edge myself and we haven't got anything like Sauce Labs setup for that (yet) so we would have to rely on acceptance testing by yourself.

joostdevries avatar Oct 29 '15 11:10 joostdevries

@joostdevries I can always do the acceptance testing. I am not sure I can write the PR but will try to find some time. If someone likes to help with this contact me.

broerse avatar Nov 02 '15 05:11 broerse

If you all create a test I can check it out.

jdalton avatar Oct 24 '16 23:10 jdalton

Update: Edge now supports srcdoc but Ember Twiddle still blocks it. See https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12375527/

Gaurav0 avatar Apr 16 '18 18:04 Gaurav0