ember-resolver icon indicating copy to clipboard operation
ember-resolver copied to clipboard

createDeprecatedModule should be striped from production builds.

Open krisselden opened this issue 9 years ago • 5 comments

krisselden avatar Jun 06 '16 23:06 krisselden

Why? Having the deprecated shims present in dev builds with a deprecation, but not present in prod builds would obviously be a breaking change.

rwjblue avatar Jun 07 '16 00:06 rwjblue

I could see doing a major bump here to drop them completely though.

rwjblue avatar Jun 07 '16 00:06 rwjblue

This was still in our production build https://github.com/ember-cli/ember-resolver/blob/5c6b080059d27d8533e57db2a5a7e7b24eb93727/vendor/ember-resolver/legacy-shims.js#L5-L9

krisselden avatar Jun 07 '16 01:06 krisselden

Right, that is because there is no infrastructure for auto-stripping these things in general. https://github.com/ember-cli/rfcs/pull/50 attempts to address this. The Ember.deprecate call there will be a noop in production builds of Ember though.

rwjblue avatar Jun 07 '16 01:06 rwjblue

@chadhietala this may be good task for you svelte tooling

stefanpenner avatar Mar 11 '17 00:03 stefanpenner