ember-cli-inject-live-reload icon indicating copy to clipboard operation
ember-cli-inject-live-reload copied to clipboard

Add CLI flag for --live-reload-js-url

Open sandstrom opened this issue 5 years ago • 4 comments

The config value liveReloadJsUrl can be set via .ember-cli but not as a command-line flag (--live-reload-js-url).

This is different from the four config values that can be set using either the config file or CLI flags (see photo).


FOR REFERENCE (photo from repo readme: https://github.com/ember-cli/ember-cli-inject-live-reload)

image

END REFERENCE


Would you be open to making liveReloadJsUrl configurable via a CLI flag? If so, is there any place in addition to the following file that needs to be modified?

https://github.com/ember-cli/ember-cli/blob/073c32eff73c58eee62d6327b50f4422f0cd01cc/lib/commands/serve.js#L62

cc @rwjblue @kellyselden happy to hear your thoughts about this

sandstrom avatar Sep 09 '20 11:09 sandstrom

@chancancode - Would this resolve the issue that you and @nullvoxpopuli were discussing RE: codesandbox the other day?

rwjblue avatar Oct 14 '20 13:10 rwjblue

@rwjblue we spend some time with gitpod integration, and looks like this option help us to not owerride .ember-cli

https://github.com/Brain-up/brn/pull/1388/files#diff-822a5719a359362df7fb6ffb57759d8c5507d206ceed8e4dd01444ac9dda7201R9

lifeart avatar Jan 14 '21 08:01 lifeart

Bump. Any chance of getting this to the finish line? Thanks!

navels avatar Oct 12 '21 20:10 navels

@navels It's almost finished actually 😄

@lifeart done an awesome work on this and fixtures (a related problem on the test side).

AFAIK it's pending a final review right now: https://github.com/ember-cli/ember-cli/pull/9430

sandstrom avatar Oct 13 '21 09:10 sandstrom