ember-cli-deploy-s3 icon indicating copy to clipboard operation
ember-cli-deploy-s3 copied to clipboard

Provide session token to credentials

Open bobisjan opened this issue 1 year ago • 1 comments

This is a followup to #190, where accessKeyId and secretAccessKey were moved to the credentials object.

The optional sessionToken is also part of credentials object in AWS SDK v3.

Fixes The AWS Access Key Id you provided does not exist in our records. error when using session token from STS service.

bobisjan avatar Jul 30 '24 11:07 bobisjan

@lukemelia 👋, can you please take a look?

bobisjan avatar Jul 31 '24 10:07 bobisjan

Hello @lukemelia,

can this please be merged?

Without this, using STS for credentials is completely broken, which is a significant issue if we want to follow best security practices and move away from using IAM users.

Thanks.

IvanVlasic avatar Jan 31 '25 10:01 IvanVlasic

@lukemelia thank you very much for quick merge!

Would you also release a new version with this fix so we can use it in our project? I've tested the fix and it works as expected.

Thank you!

IvanVlasic avatar Feb 02 '25 12:02 IvanVlasic

@lukemelia thanks for merge 🥳, I agree with @IvanVlasic, that this is a bugfix instead of enhancement, because using STS worked well before migration to AWS SDK v3, where the bug was introduced.

bobisjan avatar Feb 02 '25 13:02 bobisjan

Released as v5.0.1.

lukemelia avatar Feb 02 '25 23:02 lukemelia