ember-cli-deploy-redis icon indicating copy to clipboard operation
ember-cli-deploy-redis copied to clipboard
verified publisher icon ember-cli-deploy

improve logging for fetchRevisions

Open ghedamat opened this issue 9 years ago • 3 comments

Currently fetchRevisions is fired both on deploy and deploy:list

the log messages in the hook are NOT marked as verbose but they should be for the deploy command as they lead to confusing output for the users

ghedamat avatar Feb 06 '16 22:02 ghedamat

I notice ember-cli-deploy the other day this also is probably bred when running deploy:activate. Kind of confusing

achambers avatar Feb 07 '16 08:02 achambers

Yup @achambers

That's exactly the culprit.

Happy to chat about a decent solution!

ghedamat avatar Feb 07 '16 12:02 ghedamat

I hadn't looked in to why it happens yet. Let's chat about it. Keen to hear your thoughts. On Sun, 7 Feb 2016 at 12:40, Mattia Gheda [email protected] wrote:

Yup @achambers https://github.com/achambers

That's exactly the culprit.

Happy to chat about a decent solution!

— Reply to this email directly or view it on GitHub https://github.com/ember-cli-deploy/ember-cli-deploy-redis/issues/52#issuecomment-181005749 .

achambers avatar Feb 07 '16 13:02 achambers