ember-cli-deploy-json-config icon indicating copy to clipboard operation
ember-cli-deploy-json-config copied to clipboard

improve definition of custom selector

Open ghedamat opened this issue 9 years ago • 3 comments

as noted by @achambers in #14

Maybe what the real change needed here is a better way to define custom selectors....At the moment you either use the defaults or override the jsonBlueprint property, which means you'd need to duplicate the current default selectors and add your new ones in. Maybe we can look at a way to say, I want the default selectors and also these other custom selectors.

ghedamat avatar Jan 19 '16 13:01 ghedamat

I'm looking at taking this task on. Seems like there are some choices:

  1. Just add an option to ingest the contents of the <script> tag since that has been the impetus for two PRs so far and would also solve my use case.

  2. Breakdown the jsonBlueprint option into several properties which could be overridden jsonBlueprintBase jsonBlueprintMeta etc...

  3. User specifies a config that doesn't override jsonBlueprint and it is merged in before processing somewhere in the configure or setup hook if that is possible.

The third option seems like the best choice, but I wanted to checkin before I went down a bad path.

cc @ghedamat @achambers

jrjohnson avatar Jun 28 '16 20:06 jrjohnson

My vote is for 3). I'd like to see the plugin providing a basic default set of blueprint selectors and the then the user can specify selectors that are merged in to these defaults, instead of stomping over the top of them.

achambers avatar Jun 28 '16 21:06 achambers

PS - Love to have your contributions @jrjohnson. Thanks for taking this on. Happy to talk through these options more if you need.

achambers avatar Jun 28 '16 21:06 achambers