eslint-plugin-ember-best-practices icon indicating copy to clipboard operation
eslint-plugin-ember-best-practices copied to clipboard

Don't warn about global jquery if imported

Open knownasilya opened this issue 8 years ago • 3 comments

The new modules rfc has you using jQuery with import $ from 'jquery', but this eslint plugin doesn't handle the fact that the usage isn't via a global.

knownasilya avatar Sep 28 '17 20:09 knownasilya

I believe the original intent of that rule was to limit jQuery usage to being specifically from Ember.$ to ensure that whatever jQuery was being used was indeed the version supplied by Ember. But, I'm not 100% certain.

trentmwillis avatar Sep 30 '17 00:09 trentmwillis

I disabled mine. It could still be useful when transitioning a new app to modules, but is also a red hearing since it returns false positives.

knownasilya avatar Dec 15 '17 21:12 knownasilya

it also complains when doing import { $ } from 'Ember'; 😞

maciejmyslinski avatar Mar 05 '19 19:03 maciejmyslinski