embark
embark copied to clipboard
ci: use --coverage option when running `embark test` in test dapps
Avoid a situation where the --coverage option is not working (to an extent that embark test --coverage can't run successfully) but the problem goes undetected prior to the next stable release.
This PR is in draft because on master currently, and going back to at least the stable release of 5.0.0, embark test --coverage in dapps/tests/app doesn't work correctly (there's an unhandled exception) and it hangs indefinitely. Once that bug has been fixed, this PR can be taken out of draft and merged.
DeepCode's analysis on #b80da7 found:
- :x: 0 critical issues. :warning: 0 warnings and 0 minor issues. :heavy_check_mark: 0 issues were fixed.
:speech_balloon: This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.
:relaxed: If you want to provide feedback on our bot, here is how to contact us.
as note, the tests also seem to time out
as note, the tests also seem to time out
Yes, that behavior is related to the bug.
We'd only merge this PR after we fix the bug, the point being to catch in CI a regression or future bug/s re: --coverarge that are impactful enough to cause embark test --coverage to not complete successfully.