Michael Gasch comments

Results 240 comments of


                                            Michael Gasch

Headers duplicated when sending multiple events and using WithCustomHeader context decorator

Thx for flagging this @dan-j ! I briefly skimmed the code, and I'm not yet 100% following. Sending multiple events should invoke `Send`, i.e., `makeRequest` every single time (per event),...

Docs: How to gracefully terminate StarReceiver?

Can you please show an example how you use the HTTP client/protocol and the error you're seeing? I quickly went through the code and IMHO the protocol tries to do...

Docs: How to gracefully terminate StarReceiver?

@skillcoder Have you tried graceful shutdown via the `ctx` passed to `StartReceiver` (e.g., with `signal.NotifyContext()` to handle SIGTERM/INTERRUPT) instead of closing the protocol before? I quickly tested this with your...

IsUndelivered() returns false even when event was not delivered

I found the issue in the code: ```go diff --git a/v2/protocol/result.go b/v2/protocol/result.go index eae64e0..7ad9c3a 100644 --- a/v2/protocol/result.go +++ b/v2/protocol/result.go @@ -100,7 +100,7 @@ func (e *Receipt) Is(target error) bool {...

Receiving a JSON pubsub event

> When I try to set the ce-datacontenttype to application/json however, I find that it sometimes reverts back to application/protobuf Sorry for my late reply here. Just to fully understand,...

Replace time.Time.String() with time.Time.Format()

@MaryamTaj converted to draft, seems you're still working on this. Once ready for review, please just mark as "Ready for review" and ping us.

Replace time.Time.String() with time.Time.Format()

Glad it's sorted out! Before we merge, can you please squash/clean up commits into one?

Replace time.Time.String() with time.Time.Format()

@duglin do we consider this PR a breaking change for users? I understand our code was broken, so this would be a fix - but still could be an issue...

Replace time.Time.String() with time.Time.Format()

Yes, the existing tests might not detect it because if the producer is updated with the new semantics, the consumer will see automatically the new behavior. A test showing a...

Replace time.Time.String() with time.Time.Format()

@duglin I don't see agreement on how we want to handle the breaking change, only suggestions. Seems like we want to merge and point out in the release notes?