Michael Gasch comments

Results 199 comments of


                                            Michael Gasch

[BUG] Fix status error returned from rest code

@dougm this is also something I think we should address mid-term. Not sure about the impact on the APIs, thoughts?

[BUG] Fix status error returned from rest code

/remove-lifecycle stale

QueryTpmAttestationReport() does not get the proper PCR digest

/remove lifecycle-stale

gRPC protocol implementation

@yanmxa sorry for my delayed response on your PR, been super busy lately which impacts my availability for this SDK :/ I went through your proposal but I can't come...

gRPC protocol implementation

> Thank you, @embano1, for your thoughtful response. You're more than welcome. > Our objective is to build a robust transport layer that harnesses the efficiency of gRPC, particularly in...

Properly marshal event time to RFC-3339 format

Commented in the PR to discuss whether this must be considered a breaking change.

How to properly set Content-Encoding?

Looks like this is implemented https://github.com/cloudevents/sdk-go/blob/main/protocol/pubsub/v2/write_pubsub_message.go#L70

Feature request: Use logr instead of uber/zap directly

Using `slog` would require all users (beginning with this release) to use Go 1.21. Not sure if we should enforce this?

Could we expose sdkToProto function

Resolved #793

Provide examples how you think people should use Protobuf

@AndreasBergmeier6176 can this be closed now that `pb` got moved outside `internal`?