tree-sitter-langs icon indicating copy to clipboard operation
tree-sitter-langs copied to clipboard

dart-mode's highlighting is incorrect

Open dchrzanowski opened this issue 2 years ago • 4 comments

Hello,

The recently added dart-mode's syntax highlight is unfortunately not correct. There are multiple problems with it, basically, to be frank, it is all over the place. Example: the keyword if gets highlighted correctly in a main() method, but somewhere inside of a class' method it is just plain white. Same goes for some other keywords. Also, something like 'final' gets highlighted as a 'type' face. There are many many more errors.

dchrzanowski avatar Aug 24 '23 09:08 dchrzanowski

@jcs090218 you might wanna look into this.

meain avatar Aug 24 '23 10:08 meain

This somehow flies under my radar. Let me take a look!

jcs090218 avatar Aug 31 '23 09:08 jcs090218

I've made improvements in #226. Hope it's a lot better now! 🤔

jcs090218 avatar Sep 04 '23 05:09 jcs090218

Hi @jcs090218 I'm afraid it still is not. I have to leave now, but I'll give you a better breakdown tomorrow.

dchrzanowski avatar Sep 04 '23 14:09 dchrzanowski