sideline-flycheck
sideline-flycheck copied to clipboard
Should the sideline-flycheck faces inherit from sideline-default?
Following up on #7 -- So I found that Sideline works fine in my setup (Eglot, Flycheck) when I change the error face to inherit from variable-pitch as well:
Perfect alignment, longer error messages fit -- it's lovely.
Looking at how sideline-default and sideline-backend are used, I wonder whether at least sideline-default should be the base to inherit backends. Then users can tweak the default face and all flycheck-related faces would use that consistently as well.
At the moment, I'm using (:inherit (variable-pitch error)) for sideline-flycheck-error and adjusted the other faces accordingly:
(set-face-attribute 'sideline-flycheck-error nil
:inherit '(variable-pitch error)
:height 0.8)
(set-face-attribute 'sideline-flycheck-info nil
:inherit '(variable-pitch success)
:height 0.8)
(set-face-attribute 'sideline-flycheck-warning nil
:inherit '(variable-pitch warning)
:height 0.8)
That's not a lot of duplication, but maybe inheriting from the default style could provide a more consistent first experience -- which users will then likely tweak anyway, of course :D
Yeah, I think this makes sense! :D Would you like to open a PR for this? Sorry, I have recently had less time with Emacs packages. 😅