lsp-ui icon indicating copy to clipboard operation
lsp-ui copied to clipboard

lsp-ui-doc - stops undo working

Open dericbytes opened this issue 5 years ago • 3 comments

Undo history corrupted when lsp-ui-doc-enabled and visible

am using typescript (latest)

Write, the following to get the docs to pop up a few times.

Math.floor() Math.floor()

then call undo 4 times, it should get caught between toggling undo/redo

I was using emacs 27. I updated to nightly 28 and did a fresh install of packages. I also did a minimal install with emacs -q.

(setq lsp-ui-doc-enable t) 
(setq lsp-ui-doc-use-childframe t) 
(setq lsp-ui-doc-position 'top) 
(setq lsp-ui-doc-include-signature t)
(setq lsp-ui-doc-use-webkit t)    
(add-hook 'lsp-mode-hook 'lsp-ui-mode)

Can send more details.

dericbytes avatar Feb 26 '20 19:02 dericbytes

it should get caught between toggling undo/redo

Can you clarify what do you mean by getting caught?

I use lsp + typescript pretty regularly but never encounter your problem.

MatthewZMD avatar Feb 26 '20 20:02 MatthewZMD

undo undoes part of the text I entered. then a following undo puts back the text. then the next removes it again.

this only happens when the docs popup, which is why I gave the example of entering Math.floor().

have you tried it with the emacs settings I provided?

dericbytes avatar Feb 27 '20 23:02 dericbytes

undo undoes part of the text I entered. then a following undo puts back the text. then the next removes it again.

From what you described I do not see how the is it corrupted. I cannot reproduce this issue.

MatthewZMD avatar Mar 04 '20 15:03 MatthewZMD