Provide function to execute code lens similar to lsp-execute-code-action

[muirdm]

Apologies if I missed something, but there I couldn't find a way to execute code lens commands other than clicking on the code lens overlay text. gopls has some lenses such as "run this test" or "enable compiler detail diagnostics" where the lens text's only purpose is to allow you to run the command on the server. It would be useful to have completing read pop up with available lenses, similar to lsp-execute-code-action.

[ericdallo]

I think this is possible, but I wonder how the best way to find the lenses, I mean, should we search at the current line? search in the "function" scope? the visible buffer? For a "Run this test' lens, searching by the "function" scope would be better, but for a "enable compiler detail diagnostics", showing lens on the visible buffer maybe would be better.

[muirdm]

I don't really have good understanding of code lens use cases in general, but I might start with something like:

1. If active region, choose code lenses that start or end within region.
2. Otherwise, list all code lenses but sort them so the the ones "closest" to point come first.

[yyoncho]

There is lsp-avy-lens.

[yyoncho]

There is lsp-avy-lens.

Is that good enough for you?

[muirdm]

There is lsp-avy-lens.

Is that good enough for you?

That only shows lenses currently visible in the buffer, right? I want something that shows all the available lenses in the file.

[yyoncho]

Yes. The non-visible lenses might not be resolved so showing all lenses in the file is not an option.

[muirdm]

The non-visible lenses might not be resolved so showing all lenses in the file is not an option.

I thought the code lens response includes all lenses for the file. Isn't that enough to show a list of all lenses (that are relevant to point) and let the user select one in a completing read?

[yyoncho]

There is https://microsoft.github.io/language-server-protocol/specification#codeLens_resolve which as to be called when the server hasn't populated the lens data.

[muirdm]

Don't code actions and completion items have the same thing? We show lists of those before resolving them.

[yyoncho]

No, they don't. Consider References <Count> lenses. The heavy part is calculating the lens label. While for completion item the heavy part is not the label but calculating the additional text edits, docs, etc.

Also, in general, the completing-read won't work since you can have a lens with the same text on top of the line with the same content. In this case, you won't be able to differentiate the lens while in reality when clicking on them they will return different results. If we include the line number, it won't be fine for invisible lenses.

E. g.

<lens>
public void foo(
    ... long list of parameters)
{ 
}

<lens>
public void foo(
    ... another long list of parameters )
{ 
}

[muirdm]

Ah, I didn't realize the lens names can require resolving. Thanks.

Anyway, I still thing there should be a non-visual way to invoke lenses. If there is a code lens on my current line, I don't want to have to click or use avy to run it. I want a "traditional" Emacs command to view/execute it with a single key bind if possible.

[yyoncho]

The last one seems like to be doable. Something like M-x lsp-lens-execute which will accept directional param. It will use completing-read in case there more than one lenses grouped on one line.

[ryukinix]

Any particular interest to solve this or someone working one currently? That's something I've missing in lsp.