Hot Restart Button on Flutter Debug mode, does not work as expected.

[samuelematias]

Describe the bug On Flutter Debug mode, the Hot Restart Button, does not work as expected.

Flutter Debug Helper Palette

The Hot Restart Button

When clicked, the application closes.

Where it should actually perform the hot restart of the app, which would be the same as when using the lsp-dart-dap-flutter-hot-restart function.

To Reproduce M-x -> dap-debug -> Flutter :: Debug, with the app running and theFlutter Debug Helper Palette showing, click on the Hot Restart Button (the Green Button).

Expected behavior Hot Restart the app.

Actual behavior The app closes.

Version

[ericdallo]

Thanks for the report!

Actually that button is generic for dap-mode and that button means Restart the debug session 😅 @yyoncho maybe we could allow changing that or introduce some other entrypoint?

[elken]

Thanks for the report!

Actually that button is generic for dap-mode and that button means Restart the debug session 😅 @yyoncho maybe we could allow changing that or introduce some other entrypoint?

Just to clarify; this is the behaviour on vscode (the button does a hot restart not a full restart). Seems like there could be a dap-ui-restart-button-function or something to decide what to use to "restart" the session?

[ericdallo]

yes, ATM the dap-ui-control is generic for all languages, and dart/flutter is the only one that we want this behavior, so we need to make dap-mode accept this custom behavior change c/c @yyoncho

[yyoncho]

I think that restart implementation in dap-mode is incorrect and that it should somehow be generic and handle that case. But adding extension points is generally fine.