lsp-ltex icon indicating copy to clipboard operation
lsp-ltex copied to clipboard

lsp-ltex-active-modes has no effect

Open real-or-random opened this issue 1 year ago • 3 comments

When I set lsp-ltex-active-modes after the package is loaded, it'll be too late. It needs to be set before loading the package, but that's a bit inconvenient and not documented.

Ideally, the init code of the package should not run when loading the package, but it should be in wrapped in a function that can be called instead of (require 'lsp-ltex).

(That has also been reported as a side note in https://github.com/emacs-languagetool/lsp-ltex/issues/42.)

real-or-random avatar Jul 09 '24 09:07 real-or-random

Confirmed, you are correct. 🤔 Everything has to be configured before it's loaded.

jcs090218 avatar Nov 30 '24 08:11 jcs090218

Thanks for acknowledging. I saw that you've added the "documentation" label. Fixing the docs will certainly be an improvement. Let me say though that I think the best fix is what I described above:

Ideally, the init code of the package should not run when loading the package, but it should be in wrapped in a function that can be called instead of (require 'lsp-ltex).

real-or-random avatar Nov 30 '24 22:11 real-or-random

Sorry, I'm a bit busy these days. Anyway, feel free to open PRs for this! :)

jcs090218 avatar Dec 01 '24 03:12 jcs090218