evil-collection icon indicating copy to clipboard operation
evil-collection copied to clipboard

Smerge-mode bindings not being activated

Open Stewmath opened this issue 1 year ago • 1 comments
trafficstars

Smerge-mode bindings were added several years ago but were never added to evil-collection--supported-modes, so they never get loaded. Is there a reason for this?

Stewmath avatar Jun 03 '24 18:06 Stewmath

I tried just adding smerge (and smerge-mode) to evil-collection--supported-modes, but I couldn't get it to activate properly. I've hit the ceiling of my elisp debugging skills trying to get this to work.

(I can reproduce the issue using the clean init.el from the readme)

It'd be nice if someone more knowledgeable can have a look 😌


In the meantime (add-hook 'smerge-mode-hook 'evil-collection-smerge-mode-setup)) works.

cobac avatar Sep 10 '24 08:09 cobac

Thanks @jojojames ❤️ , confirmed it works as expected with your latest commit!

cobac avatar Nov 24 '24 09:11 cobac