evil-collection icon indicating copy to clipboard operation
evil-collection copied to clipboard

helm: hide evil cursor in minibuffer

Open taquangtrung opened this issue 2 years ago • 1 comments
trafficstars

Brief summary of what the package does

Hi,

This PR enables hiding cursor in minibuffer when a Helm session is active.

I fixed the issue that was previously mentioned in https://github.com/emacs-evil/evil-collection/issues/63, but it wasn't fixed until now.

Can you consider merging?

Thanks!

Checklist

Assume you're working on mpc mode:

  • [x] byte-compiles cleanly
  • [x] M-x checkdoc is happy. Don't manually write (provide 'evil-collection-mpc), M-x checkdoc can do it automatically for you
  • [ ] define evil-collection-mpc-setup with defun
  • [ ] define evil-collection-mpc-mode-maps with defconst
  • [ ] All functions should start with evil-collection-mpc-

taquangtrung avatar May 23 '23 13:05 taquangtrung

Eager macro-expansion failure: (wrong-number-of-arguments (2 . 2) 4)
Requiring evil-integration. Set evil-want-integration to t to remove this message.

See https://github.com/emacs-evil/evil-collection/issues/60 for more details.

In toplevel form:
modes/helm/evil-collection-helm.el:69:1:Error: Wrong number of arguments: (2 . 2), 8
make: *** [Makefile:11: compile] Error 1

Emacs 26.3 throws an error.

condy0919 avatar May 30 '23 16:05 condy0919