elysia icon indicating copy to clipboard operation
elysia copied to clipboard

Published 20 hours ago • verified publisher icon elysiajs

Semver not followed correctly

Open cybercoder-naj opened this issue 1 year ago • 2 comments

What version of Elysia.JS is running?

1.1.0

What platform is your computer?

Linux 6.6.32-1-lts x86_64 unknown

What steps can reproduce the bug?

Upgrade an existing project from v1.0.x to v1.1.0.

What is the expected behavior?

Do not have any breaking changes.

What do you see instead?

Breaking changes with the onResponse function.

Additional information

According to SemVer, MINOR version when you add functionality in a backward compatible manner. I don't think it was necessary to rename the function and publish the breaking change as a minor version upgrade.

cybercoder-naj avatar Jul 16 '24 16:07 cybercoder-naj

as an option, leave it deprecated)

kravetsone avatar Jul 17 '24 09:07 kravetsone

Agreed. decommissioned functions conventionally should be marked as deprecated until the next major release. I assume many libraries and production codes would break due to this change.

cybercoder-naj avatar Jul 17 '24 10:07 cybercoder-naj