virtual-dom

virtual-dom copied to clipboard

Redundant removal and reinsertion of node breaks focus on element

6

I have a table with a variable number of columns. The right-most column of the top row contains a button element which receives focus using an initial command when the...

bisgardo

Chrome extensions (Grammarly in our case) cause runtime errors

3

[This PR is a re-posting of this fix](https://discourse.elm-lang.org/t/runtime-errors-caused-by-chrome-extensions/4381/15) These patches fix the issue below. Here's the expanded stack trace. ``` Main.elm:3676 Uncaught TypeError: Cannot read properties of undefined (reading 'childNodes')...

erlandsona

Use Object.create(null) instead of {} to compute keyed diffs

2

This is a minor improvement pull request. `{}` creates an empty object but which still contains methods and properties like `toString`. Checking `changes[key]` when the key is for instance `toString`...

jfmengels

Allow CSS custom properties by using style.setProperty()

16

When using custom css properties the syntax `style.property = 'value'`does not work for custom css properties. Instead, using `style.setProperty()` allows custom css properties to be set. I would like to...

harrysarson

`javascript:` ban disallows legitimate use for bookmarklets

4

See https://github.com/Janiczek/ellies/issues/3 I want to create a [bookmarklet](https://support.mozilla.org/en-US/kb/bookmarklets-perform-common-web-page-tasks), which means an `link` that I can drag to my bookmarks tab and there click on it to perform some JS on...

Janiczek

The Elm runtime crashes when `` is used. Other XSS examples are correctly encoded. Minimal example: ```elm import Html exposing (text) main = text "" ``` Result: ```javascript _Platform_export({'Main':{'init':_VirtualDom_init($author$project$Main$main)(0)(0)}});}(this)); var...

mkoppmann

Fixes #103 Html.map + blur event on DOM removal makes impossible states possible

7

Updated SSCCE: https://ellie-app.com/8cPfM8xMj7Za1 This issue happens in chrome, and not firefox (as mentioned on #103). To see the issue on the SSCCE above: * press "Go to B" * look...

decioferreira

Reporting @hariroshan issue https://github.com/elm/compiler/issues/2245 here as advised by @jfmengels.

laurentpayot

Custom element extended built-in support and special `is` attribute

7

[`document.createElement`](https://developer.mozilla.org/en-US/docs/Web/API/Document/createElement#Web_component_example) support additional options, namely `is` for [custom elements that are extended](https://developer.mozilla.org/en-US/docs/Web/API/Document/createElement#Web_component_example). You can see that [no additional arguments are sent to `document.createElement`](https://github.com/elm/virtual-dom/blob/4ff4f5a17c7406e2fb66f7c78899d91f7c48646e/src/Elm/Kernel/VirtualDom.js#L456). Since custom elements are a goto solution...

toastal

Only divert href to app if there is an href for an anchor tag.

7

Addresses issue raised at https://github.com/elm/browser/issues/34 which appears to check out, when you take a look at the HTML specification.

Pilatch