elixir-tools.vscode icon indicating copy to clipboard operation
elixir-tools.vscode copied to clipboard

Cache latest release when the network is unavailable

Open mhanberg opened this issue 2 years ago • 4 comments

Basically, this functionality from elixir-tools.nvim should be ported over to elixir-tools.vscode.

mhanberg avatar Jun 26 '23 02:06 mhanberg

@mhanberg I'm looking at this one and I just wanted to confirm my understanding (or lack of it). latestRelease just gets the version string. It's not actually downloading the latest binary. Is that right?

If so, then I don't understand why we need to do that. Shouldn't the version string just match the binary deployed with the extension? What's the purpose of fetching the latest version string when we aren't getting the matching binary of that release?

CoderDennis avatar Jul 21 '23 09:07 CoderDennis

I'm looking at this one and I just wanted to confirm my understanding (or lack of it). latestRelease just gets the version string. It's not actually downloading the latest binary. Is that right?

This is correct

Shouldn't the version string just match the binary deployed with the extension?

The extension is designed so that it will automatically install the latest versions of Next LS and Credo Language Server, without me having to release a new version of the extension.

There isn't really a binary deployed with the extension, it is a bootstrapping script that will run Mix.install with the release version fetched from the GitHub API.

mhanberg avatar Jul 21 '23 15:07 mhanberg

Oh! That makes sense. Thanks!

CoderDennis avatar Jul 21 '23 15:07 CoderDennis

No longer relevant for NextLS

mhanberg avatar Aug 10 '23 20:08 mhanberg