elixir_make icon indicating copy to clipboard operation
elixir_make copied to clipboard

gmake vs make ✨🤕

Open hrefhref opened this issue 5 years ago • 4 comments

So #37 made me think. The majority of Elixir projects will write Makefile for GNU make, so developers expects that elixir_make will always use it.

That PR added netbsd, but there's also solaris, smartos, dragonfly, …. How can we find a way to ensure we'll use gmake consistently ?

Could we just call gmake if :os.type() isn't {:unix, :linux} ? I can't really think of any other unices that bundles gnu make as a default.

hrefhref avatar Jul 10 '20 20:07 hrefhref

In practice, except if you're running HURD, every non-linux UNIX runs their own flavour of non-GNU make.

Kleidukos avatar Jul 10 '20 20:07 Kleidukos

Has this caused actual problems that we are aware of? I want to make sure we're not spending time designing a super generic solution when no one actually ran into anything bad related to this, you know 😄

whatyouhide avatar Jul 20 '20 12:07 whatyouhide

Hi @whatyouhide! Issues were raised while testing a software called Pleroma written in Elixir, on different Unices. The goal is not to spend time designing a super generic solution, but to actively promote the use of the gmake executable by default on all non-Linux Unices. A generic solution would account for every flavours of Make in the Unix world. The solution that is proposed is to specialise rather than generalise.

Kleidukos avatar Jul 21 '20 08:07 Kleidukos

I'm not super familiar with all the Make stuff (😅) so I'm good with making gmake default on all non-Linux Unix systems. Could you send a PR @Kleidukos? :)

whatyouhide avatar Jul 23 '20 13:07 whatyouhide

A PR for using gmake in other Unices is welcome if you still believe ti is a useful change. Closing this for now!

josevalim avatar Aug 17 '22 11:08 josevalim