inbox-zero
inbox-zero copied to clipboard
Hide congrats confetti when not on inbox tab
Celebration Component Improvements
Component Updates:
apps/web/components/Celebration.tsx:- Added optional
confettiprop to control the display of confetti. - Conditionally render the "Congrats!" text and confetti based on the
confettiprop.
- Added optional
Integration:
apps/web/components/email-list.tsx:- Updated to pass the
confettiprop dynamically (type !== "inbox") when using theCelebrationcomponent.
- Updated to pass the
Closes #123
Summary by CodeRabbit
- Enhancements
- Updated the empty email list display: now shows a celebration message only for the inbox, while other folders display a neutral "No emails to display" message.
@Francisca105 is attempting to deploy a commit to the Inbox Zero Team on Vercel.
A member of the Team first needs to authorize it.
Walkthrough
The change updates the empty state rendering logic in the email list component. Now, the celebratory "Inbox Zero" message is shown only when the email list type is "inbox". For all other types, such as "drafts", a neutral informational message is displayed instead. The generic celebration message for non-inbox types has been removed, and no changes were made to the component's exported interface.
Changes
| File(s) | Change Summary |
|---|---|
| apps/web/components/email-list/EmailList.tsx | Updated empty state logic: celebration message now shown only for "inbox" type; others show neutral text. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Only show "Inbox Zero" celebration on inbox tab, not on others (#123) | β |
Poem
A rabbit hops through inbox land,
Where empty lists are simply grand.
No more confetti for every tabβ
Just inbox cheers, the rest stay fab.
Drafts and sent now calmly say,
"No emails here, just hop away!"
πβ¨
[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.
π§ ESLint
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
apps/web/components/email-list/EmailList.tsx
Oops! Something went wrong! :(
ESLint: 9.23.0
ESLint couldn't find an eslint.config.(js|mjs|cjs) file.
From ESLint v9.0.0, the default configuration file is now eslint.config.js. If you are using a .eslintrc.* file, please follow the migration guide to update your configuration file to the new format:
https://eslint.org/docs/latest/use/configure/migration-guide
If you still have problems after following the migration guide, please stop by https://eslint.org/chat/help to chat with the team.
[!TIP]
β‘π¬ Agentic Chat (Pro Plan, General Availability)
- We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
π Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
π₯ Commits
Reviewing files that changed from the base of the PR and between 3dadaa9242bc94c8ca57830afd32ff3a99325116 and bdb2d328836fb8f5574d170b06575b79dc215f19.
π Files selected for processing (1)
apps/web/components/email-list/EmailList.tsx(1 hunks)
π§ Files skipped from review as they are similar to previous changes (1)
- apps/web/components/email-list/EmailList.tsx
πͺ§ Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@elie222 Could you please take a look? Would love to hear your thoughts!
Hey, instead of passing in props to change the congrats component, we can just show a message instead:
"No emails" Or what Gmail does: "There are no conversations with this label."
So would be st like this:
{type === "inbox" ? <Celebration /> : "No emails"}
I've updated the code to display a simple message instead of using the Celebration component outside of the inbox, as requested. Here's a preview of how it looks now on the page:
I also added some basic styling to maintain consistency (you can check out the changes here)
Let me know if this looks good to you or if you'd prefer any adjustments!
@elie222 Could you take a look at the changes and let me know if this meets what you had in mind? Thanks!