inbox-zero icon indicating copy to clipboard operation
inbox-zero copied to clipboard

add multi-email input component and refactor compose email form

Open yashsharma999 opened this issue 8 months ago • 3 comments

closes #368

https://www.loom.com/share/641f7db9d9294edabfecbcc1c8180810?sid=20501053-759b-4b2f-93a8-09bf24e9bf4e

Summary by CodeRabbit

  • New Features
    • Enhanced the email composition interface with improved recipient fields.
    • Introduced a dynamic mailbox component that provides toggling options for additional fields like Cc and Bcc.
    • Added support for managing multiple email addresses with robust validation and formatting improvements.
    • Updated form behavior to consistently handle recipient inputs, ensuring a smoother email composition experience.

yashsharma999 avatar Apr 01 '25 23:04 yashsharma999

@yashsharma999 is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 01 '25 23:04 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 01 '25 23:04 CLAassistant

Walkthrough

This PR updates the email composition functionality. In the ComposeEmailForm, default values for cc and bcc are set to empty strings, and the form’s onSubmit logic now converts email fields from arrays to comma-separated strings. The old email input is replaced by a new ComposeMailBox component, which manages the display of additional fields via toggle buttons. Additionally, a new MultiEmailInput component is introduced to handle multiple email entries with regex validation and state management for form registration.

Changes

File(s) Change Summary
…/compose/ComposeEmailForm.tsx Updated default values for cc and bcc; revised onSubmit logic to convert email arrays to comma-separated strings; reintroduced SendEmailBody type; replaced the traditional <Input> with the ComposeMailBox component.
…/compose/ComposeMailBox.tsx, …/compose/MultiEmailInput.tsx Added new components: ComposeMailBox (along with ToggleButtonsWrapper and ToggleButton) enables dynamic Cc/Bcc handling. MultiEmailInput provides multi-email entry, regex validation, state management, and integration with form registration.

Sequence Diagram(s)

sequenceDiagram
    participant User as User
    participant Form as ComposeEmailForm
    participant MailBox as ComposeMailBox
    participant Server as Server

    User->>Form: Enter email details (to, cc, bcc)
    Form->>MailBox: Render email input fields with toggles for Cc/Bcc
    User->>MailBox: Toggle Cc/Bcc fields as needed
    MailBox->>MailBox: Update internal display state
    User->>Form: Submit form
    Form->>Form: Convert email arrays to comma-separated strings
    Form->>Server: Send processed email data
sequenceDiagram
    participant User as User
    participant MEI as MultiEmailInput
    participant Reg as Form Registration

    User->>MEI: Type email address(es)
    MEI->>MEI: Validate emails using regex and update state
    MEI->>Reg: Pass comma-separated email values for form submission

Assessment against linked issues

Objective Addressed Explanation
Update multi input on compose form (#368)

Possibly related PRs

  • elie222/inbox-zero#220: Involved adjustments to the ComposeEmailForm.tsx, focusing on email input handling, which relates to the changes in this PR.

Poem

I'm a rabbit hopping in the code glade,
Where email forms bloom in a cascade.
With toggles and inputs, I bound along,
Crafting code in a harmonious song.
Hoppy changes make my heart skip a beat!
🐇✨

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/app/(app)/compose/ComposeEmailForm.tsx

Oops! Something went wrong! :(

ESLint: 9.23.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js. If you are using a .eslintrc.* file, please follow the migration guide to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by https://eslint.org/chat/help to chat with the team.

apps/web/app/(app)/compose/MultiEmailInput.tsx

Oops! Something went wrong! :(

ESLint: 9.23.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js. If you are using a .eslintrc.* file, please follow the migration guide to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by https://eslint.org/chat/help to chat with the team.

apps/web/app/(app)/compose/ComposeMailBox.tsx

Oops! Something went wrong! :(

ESLint: 9.23.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js. If you are using a .eslintrc.* file, please follow the migration guide to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by https://eslint.org/chat/help to chat with the team.

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 01 '25 23:04 coderabbitai[bot]