obsidian-annotator icon indicating copy to clipboard operation
obsidian-annotator copied to clipboard

annotator catches every keyboard input, even when not active

Open bitSheriff opened this issue 3 years ago • 2 comments

if you have annotator in a second pane opened, and you navigate with the arrow-keys, the annotator catches these inputs and moves to the next page, even if the pane is not selected

Annotator-Version: 0.2.6 Obsidian-Version: 0.15.9

bitSheriff avatar Aug 20 '22 17:08 bitSheriff

same issue Annotator-Version: 0.2.2 Obsidian-Version: 0.14.15

AINightCoder avatar Sep 07 '22 14:09 AINightCoder

Probably the problem is in the file defineEpubAnnotation.tsx grafik

A good solution would be to check the context, if the annotator pane is currently focused. Sadly, I don't have any experience in TypeScript. Another solution would be to have another (boolean) settings which turns off the page turning by the arrow keys.

@elias-sundqvist & @aladmit any idea if this bug will get fixed soon?

bitSheriff avatar Oct 29 '22 18:10 bitSheriff

This code in defineEpubAnnotation executes only when epub reader open, but the but persists in all other annotation modes too(web, YouTube, pdf). That's why I think that's an issue with iframe.

any idea if this bug will get fixed soon?

I'll not to be able to develop the plugin for a few more months. So, maybe it will be fixed somewhere in January, I don't know, it's hard to say right know.

P.S. I'm closing this issue because it's a dup of #161

aladmit avatar Oct 30 '22 05:10 aladmit

Thanks for the clarification :)

bitSheriff avatar Oct 30 '22 07:10 bitSheriff