retry4j icon indicating copy to clipboard operation
retry4j copied to clipboard

Published 20 hours ago • verified publisher icon elennick

parameterize retrying-on-value

Open elennick opened this issue 7 years ago • 2 comments

https://github.com/elennick/retry4j/blob/master/src/main/java/com/evanlennick/retry4j/config/RetryConfig.java#L20

Retrying by value doesn't need to just use a vague Object like this... we know what the type is. Can use generics to more strongly type this to whatever the return value of the Callable is.

elennick avatar Feb 13 '18 04:02 elennick

Can you share the status of this issue, please. I've seen that there was the PR #64, but it's closed. I'd like to extend this to accept null values. Maybe it will be needed to add a new method aka retryOnNull, not sure yet.

dev3loperb avatar Aug 12 '18 20:08 dev3loperb

@ipergenitsa I started investigating resolving it a while back but wasn't happy with the direction my solution was taking so I closed that PR. If you'd like to take another stab at it and submit a PR that would be totally fine... i can assign this to you for now to look into.

elennick avatar Aug 12 '18 21:08 elennick