tasks icon indicating copy to clipboard operation
tasks copied to clipboard

Scheduled List: Fix has-due? and has-start?

Open marbetschar opened this issue 5 years ago • 4 comments

As EDS added support for has-end?, has-due? and has-duration? in 3.39.1+, we should also fix our s-expression for the Scheduled List in MainWindow.vala:

var query = "AND (NOT is-completed?) (OR (has-start?) (has-alarms?))";

According to RFC554, either dtstart or due can be set - so our s-expression should be changed to:

var query = "AND (NOT is-completed?) (OR (has-start?) (has-due?))";

@danrabbit will Evolution Data Server 3.39.1+ eventually land in Odin?

marbetschar avatar Oct 09 '20 09:10 marbetschar

Sidenote: Whether EDS lands in Odin or not, in every case we want to remove has-alarms? from the s-expression - https://github.com/elementary/tasks/pull/147 does take care of this.

marbetschar avatar Oct 09 '20 09:10 marbetschar

@marbetschar at this point we're past the freeze in Ubuntu, so we'd have to backport it ourselves. It looks like we're currently on 3.36.4. My assumption would be that we wouldn't normally backport something like EDS because Canonical maintains security patches for what's in their repos, but @tintou would have more of an opinion on this

danirabbit avatar Oct 10 '20 00:10 danirabbit

iOS Reminders sets both properties (start and due), so I guess we are fine if we do the same. Then we can simply query for (has-start?). The needed changes for this to work is implemented in #147.

Although I don't know about other Task/Reminder Apps. I guess the most interesting part here would be to know how a broadly used one on Android behaves (I guess thats Tasks) to figure out if we are on the right track here.

marbetschar avatar Oct 10 '20 09:10 marbetschar

I would indeed avoid as much backport as we can as it would mean that we have to support it for 3 years ourselves… We will be flatpak-native at some point which would simplify issues like this a bit.

tintou avatar Oct 12 '20 08:10 tintou