switchboard-plug-pantheon-shell icon indicating copy to clipboard operation
switchboard-plug-pantheon-shell copied to clipboard

Add support for antialias and related subpixel order settings

Open jhaygood86 opened this issue 4 years ago • 5 comments

This adds selectors for antialiasing, and if subpixel antialias is chosen, the subpixel order. It actually renders the labels within the mode buttons using the text settings selected so the user can see how it will look in advance and select the best looking version.

Example screenshot:

Screenshot from 2021-09-04 19-48-13

Fixes #288

jhaygood86 avatar Sep 04 '21 23:09 jhaygood86

I think the spacing between the newly added options should be increased, because now the options seem too closely packed

kdwk avatar Sep 05 '21 01:09 kdwk

Screenshot from 2021-09-05 19 10 06

Added some margins between the new settings.

jhaygood86 avatar Sep 05 '21 23:09 jhaygood86

My inclination with these additional text-related options is that we should move this layout over to a sidebar with:

  • Wallpaper
  • Appearance (or Style?)
  • Text (is that the best name?)
  • Dock & Panel
  • Multitasking

Does that make sense @elementary/ux?

cassidyjames avatar Sep 08 '21 20:09 cassidyjames

@cassidyjames yeah ultimately moving to a sidebar would be better imo. For the purposes of this PR, it would probably be good just to split the text options off into another tab

I'd also be inclined to use radios for these options instead of modebuttons

danirabbit avatar Sep 08 '21 20:09 danirabbit

Screenshot from 2021-09-09 08-14-22

Added a new "Text" tab and moved text related settings there. Switched mode buttons to radio buttons for new settings

jhaygood86 avatar Sep 09 '21 12:09 jhaygood86