switchboard-plug-network
switchboard-plug-network copied to clipboard
elementary
Avoid compilation warnings about deprecated call
As of NetworkManager 1.22, a lot of function should be asynchronously called.
This MR remove all the compilation warning still visible (at least on Archlinux). Maybe it’s only preparatory stuff for Debian/Ubuntu distros.
Hey sorry it took me so long to follow up on this, I didn't see your replies for some reason 😓
No problem. I’ll change the code in this direction then.
We still have one last issue regarding various wifi state. I didn’t take time either to look for a better solution than just activating the spinner. If I don’t find more time or a working solution for now, I might just rollback my change and just insert a TODO for a better skilled person (I’m very poor when it comes to design/UX).
Ok, I just take time to do it now. I also work on missing NM.DeviceState. From my point of view it was finally not that hard. However I did introduce new translation terms, don’t know if you are ok with that or not.
Hey sorry for not reviewing promptly. This has been hard to review because it changes several unrelated things that all have to be reviewed separately. It's much better to propose separate branches with unrelated changes.
Hi, and verry sorry for the long silence.
I just rebased the branch on the last main state, updating it for gtk4 port.
Can you revert the changes in WifiMenuItem and propose that separately? That doesn't seem related to resolving the deprecation warnings with NM
Actually my changes there were to address a warning about missing states in the switch/case statement, thus for me it’s still related to the topic of this MR (removing as much warning as possible). However I can understand you prefer to separate each fix step. Can you confirm your prefer 3 different MR?
@milouse Yes please 3 separate pull requests would make a lot more sense here. The change to use async methods I can easily approve and merge immediately but the changes to the proxy enum I think might need some further investigation and the changes to the wifitem definitely needs a completely separate review as well