stylesheet icon indicating copy to clipboard operation
stylesheet copied to clipboard

Round and shadow framed rich-list

Open danirabbit opened this issue 3 years ago • 4 comments

Problem

Screenshot from 2022-05-26 14 15 44

Proposal

Screenshot from 2022-05-26 14 15 51

.rich-list.frame {
border-radius: 6px;
box-shadow: 0 1px 3px alpha(#000, 0.1);
margin-bottom: 3px;
}

.rich-list.frame row {
padding: 6px 12px;
}

Prior Art (Optional)

No response

danirabbit avatar May 26 '22 21:05 danirabbit

FWIW the lists in inspector and gtk4-demo use GtkFrame rather than .frame.

In libadwaita we ended up renaming libhandy's .content to .boxed-list and just use that and leaving .rich-list to die. I also hope to eradicate it from GTK5. :)

alice-mkh avatar May 26 '22 22:05 alice-mkh

Yeah this is the only place we ever use this pattern tbh. I suppose it would be better to match what Gtk or Adw are doing. I don't have strong feelings here

danirabbit avatar May 27 '22 01:05 danirabbit

Well, one thing I want to do is to get .boxed-list into GTK itself, so we can have nice looking lists in inspector. In that case IMO it would make sense for you to match that, but of course right now it's a libadwaita-only thing...

Another place I'd like to use that in is libgcr -the gtk4 port uses a lot of boxed lists, and those are again GtkFrame + .rich-list inside it, so the style is broken and not fixable.

Might be worth it to poke gtk people.

alice-mkh avatar May 27 '22 17:05 alice-mkh

Based on the conversation we had in Matrix I'm gonna continue in this direction using a frame class instead of a Gtk.Frame. And then at whatever point class names are decided in Gtk I'll migrate the styles to use the upstream names. Thanks for taking the conversation upstream!

danirabbit avatar May 28 '22 06:05 danirabbit

Closing since .boxed-list is now supported

danirabbit avatar Mar 24 '23 00:03 danirabbit