files icon indicating copy to clipboard operation
files copied to clipboard

Published 20 hours ago • verified publisher icon elementary

Rename using a popover

Open tintou opened this issue 7 years ago • 7 comments

It's what GNOME is doing and it allows us to use a native widget for the input

tintou avatar Apr 14 '18 01:04 tintou

Gonna poke @elementary/ux for this

tintou avatar Apr 14 '18 01:04 tintou

I prefer the experience of doing it inline (like on Windows and macOS), but if a popover is cleaner I'm not totally opposed.

cassidyjames avatar Apr 14 '18 05:04 cassidyjames

It should be much easier to implement this way, with much less code.

jeremypw avatar Apr 14 '18 07:04 jeremypw

I'm really -1 on the popover. IMO it feels janky. I don't think we should have more than one "context menu" for a single item.

danirabbit avatar Apr 15 '18 22:04 danirabbit

I would envisage this more as an overlay just containing an Entry, that appears instead of the editable widget of the text renderer ( and in the same place). It is not really a menu. It could be used for all views rather than having two different editable widgets.

jeremypw avatar Apr 16 '18 16:04 jeremypw

I think an overlaid entry that is positioned below the icon works for me. I'd be curious to see it.

cassidyjames avatar Apr 23 '18 20:04 cassidyjames

The draft Gtk4 version is currently using a dialog to rename as there were technical difficulties using inline naming with a dynamic view. I'll try to overlay it on the icon being renamed in future, if possible.

jeremypw avatar Jun 25 '23 12:06 jeremypw