Split style scheme GSettings into light and dark

[cassidyjames]

trafficstars

Right now we have one style scheme GSetting that we manually change every time you use the light or dark buttons in the style switcher. Instead, we could have a light GSetting and dark GSetting, and just toggle between them with the buttons.

• [ ] Change the UI to just say, "Light" and "Dark" instead of anything about "Solarized" OR programmatically grab the name of the relevant style scheme
• [ ] Create the new GSettings
• [ ] Change the scheme based on the GSetting
• [ ] Make sure we still load the correct one at runtime

This makes it a little easier for downstreams to set their own default light and dark color schemes if they want.

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[danirabbit]

Probably what we could do with the least amount of damage to current settings is to introduce a key style-scheme-dark and then we save/load the style scheme from style-scheme or style-scheme-dark depending on the value of prefer-dark-style

[jeremypw]

@danirabbit Doesn't this assume that we only provide two themes and always fallback to classic for "high contrast". I have proposed an elementary highcontrast theme that hopefully improves on classic. In which case should we also have a "style-scheme-highcontrast" key?