synapse
synapse copied to clipboard
appservice: Add {as,hs}_token_path config options
Adds the config options as_token_path and hs_token_path to the application service configuration. A gratis unit test is part of the deal!
Pull Request Checklist
- [x] Pull request is based on the develop branch
- [x] Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from
EventStoretoEventWorkerStore.". - Use markdown where necessary, mostly for
code blocks. - End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from
- [x] Code style is correct (run the linters)
I get the idea, but one thing is that the appservice registration files are supposed to be standard, defined by the spec: https://spec.matrix.org/v1.13/application-service-api/
Will raise that to the rest of the team, but I feel like this change will likely have to go through a spec change
So technically, this isn't allowed by the spec, but we could support this as a synapse 'extension'. Or you should open an MSC to extend the AS spec and support specifying a path for those. What do you think @V02460?