element-x-ios icon indicating copy to clipboard operation
element-x-ios copied to clipboard

Expand the CallScreen into the safe area and let ElementCall handle layout

Open stefanceriu opened this issue 1 year ago • 4 comments

stefanceriu avatar Aug 29 '24 07:08 stefanceriu

Warnings
:warning: Please provide a description for this PR.
:warning: Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
:warning: You seem to have made changes to views. Please consider adding screenshots.

Generated by :no_entry_sign: Danger Swift against 1f4e94d0a9f7c19867481e0f085f56d3f24e73d0

github-actions[bot] avatar Aug 29 '24 07:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.51%. Comparing base (e439689) to head (1f4e94d). Report is 108 commits behind head on develop.

Files with missing lines Patch % Lines
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 5 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3210      +/-   ##
===========================================
+ Coverage    77.50%   77.51%   +0.01%     
===========================================
  Files          722      722              
  Lines        57218    57242      +24     
===========================================
+ Hits         44345    44372      +27     
+ Misses       12873    12870       -3     
Flag Coverage Δ
unittests 68.29% <0.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 29 '24 07:08 codecov[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 06 '24 13:09 CLAassistant

This is not on the table just yet and I got tired of seeing it around. Can be restored later if need be.

stefanceriu avatar Sep 27 '24 06:09 stefanceriu