element-x-android icon indicating copy to clipboard operation
element-x-android copied to clipboard

Display non-technical error on media gallery

Open jmartinesp opened this issue 2 months ago • 3 comments

This way, we can customise the error to display (throwable.message, throwable.localizeMessage, or any other error message we want).

Content

Motivation and context

Fixes https://github.com/element-hq/element-x-android/issues/5483

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • [ ] Physical
  • [ ] Emulator
  • OS version(s):

Checklist

  • [ ] Changes have been tested on an Android device or Android emulator with API 24
  • [ ] UI change has been tested on both light and dark themes
  • [ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • [ ] Pull request is based on the develop branch
  • [ ] Pull request title will be used in the release note, it clearly define what will change for the user
  • [ ] Pull request includes screenshots or videos if containing UI changes
  • [ ] You've made a self review of your PR

jmartinesp avatar Oct 08 '25 11:10 jmartinesp

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7QStVg

github-actions[bot] avatar Oct 08 '25 11:10 github-actions[bot]

Codecov Report

:x: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 81.93%. Comparing base (4c358ae) to head (6ed35b0). :warning: Report is 595 commits behind head on develop.

Files with missing lines Patch % Lines
.../mediaviewer/impl/gallery/MediaGalleryPresenter.kt 0.00% 1 Missing and 1 partial :warning:
...aries/mediaviewer/impl/gallery/MediaGalleryView.kt 50.00% 0 Missing and 2 partials :warning:
...es/mediaviewer/impl/viewer/MediaViewerPresenter.kt 0.00% 1 Missing and 1 partial :warning:
...ies/mediaviewer/impl/gallery/MediaGalleryEvents.kt 0.00% 1 Missing :warning:
...aries/mediaviewer/impl/viewer/MediaViewerEvents.kt 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5487      +/-   ##
===========================================
- Coverage    81.93%   81.93%   -0.01%     
===========================================
  Files         2371     2371              
  Lines        67207    67215       +8     
  Branches      8112     8115       +3     
===========================================
+ Hits         55069    55071       +2     
- Misses        9163     9167       +4     
- Partials      2975     2977       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 08 '25 12:10 codecov[bot]