element-x-android
element-x-android copied to clipboard
[Extremely WIP] Emoji reaction skin tone selection
trafficstars
Content
Motivation and context
Screenshots / GIFs
Tests
- Step 1
- Step 2
- Step ...
Tested devices
- [ ] Physical
- [ ] Emulator
- OS version(s):
Checklist
- [ ] Changes have been tested on an Android device or Android emulator with API 23
- [ ] UI change has been tested on both light and dark themes
- [ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
- [ ] Pull request is based on the develop branch
- [ ] Pull request title will be used in the release note, it clearly define what will change for the user
- [ ] Pull request includes screenshots or videos if containing UI changes
- [ ] Pull request includes a sign off
- [ ] You've made a self review of your PR
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
- Your branch should be based on
origin/develop, at least when it was created. - The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
- The test pass locally running
./gradlew test. - The code quality check suite pass locally running
./gradlew runQualityChecks. - If you modified anything related to the UI, including previews, you'll have to run the
Record screenshotsGH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.
Hello @frebib , please see my comment on your other PR: https://github.com/element-hq/element-x-android/pull/2892#issuecomment-2670782197 that also applies fro this one. Thanks!
Closing the PR.